Fix #14 + #15 - Validators::is() with pipe#31
Closed
Majkl578 wants to merge 2 commits into
Closed
Conversation
added pattern string with pipe (regex alternative) character
Contributor
Author
|
Note that this would still fail for a case like this: But the chance is 1000x lower. No better idea about some generic solution without BC breaks. |
Majkl578
changed the title
|
what about this syntax |
Member
|
This is not deterministic 👎 |
Contributor
Author
|
Yup, any better solution without BC breaks? |
Member
|
dg
force-pushed
the
master
branch
2 times, most recently
from
5617d88 to
209844d
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
5ed86bc to
509ef5e
Compare
dg
force-pushed
the
master
branch
13 times, most recently
from
6c03b1f to
a4bddc8
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
2998062 to
f6303c6
Compare
Member
|
Won't fix is IMHO the best solution, thanks anyway for PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix for #14 & #15.